Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: listen to podman desktop container api events #194

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jan 30, 2024

Description

This PR add a ContainerRegistry, is purpose is to listen to containers events emitted by the PodmanDesktop core, such as die | remove | start etc.

This registry allow the playground to subscribe to the notification of a certain containerId (the one it created) so if something external is deleting the containers, the playgrounds will know it.

Screenshots / video

podman-listen-events.mp4

Related issues

Fixes #110

Testing

  • Unit tests

@axel7083 axel7083 self-assigned this Jan 30, 2024
@axel7083 axel7083 requested review from feloy and lstocchi and removed request for feloy January 30, 2024 14:22
@axel7083 axel7083 force-pushed the feature/110-listen-containers-events branch from c34eb32 to 1ddf013 Compare January 30, 2024 15:09
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

@axel7083
Copy link
Contributor Author

LGTM, great!

@feloy I will wait for #193 being merged so you do not have to resolve the conflicts created by this one !

@feloy
Copy link
Contributor

feloy commented Jan 30, 2024

LGTM, great!

@feloy I will wait for #193 being merged so you do not have to resolve the conflicts created by this one !

merged, thanks

@axel7083 axel7083 force-pushed the feature/110-listen-containers-events branch from 9426d93 to 0b63c09 Compare January 30, 2024 17:10
Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 enabled auto-merge (squash) January 30, 2024 17:14
@axel7083 axel7083 merged commit 83bc710 into main Jan 30, 2024
3 checks passed
@axel7083 axel7083 deleted the feature/110-listen-containers-events branch January 30, 2024 17:18
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Add common Makefile to share between recipes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground should _listen_ to containers update
2 participants