-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: listen to podman desktop container api events #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel7083
requested review from
feloy and
lstocchi
and removed request for
feloy
January 30, 2024 14:22
axel7083
force-pushed
the
feature/110-listen-containers-events
branch
from
January 30, 2024 15:09
c34eb32
to
1ddf013
Compare
feloy
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great!
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
axel7083
force-pushed
the
feature/110-listen-containers-events
branch
from
January 30, 2024 17:10
9426d93
to
0b63c09
Compare
Signed-off-by: axel7083 <[email protected]>
This was referenced Feb 2, 2024
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
Add common Makefile to share between recipes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a
ContainerRegistry
, is purpose is to listen to containers events emitted by the PodmanDesktop core, such asdie | remove | start
etc.This registry allow the playground to subscribe to the notification of a certain containerId (the one it created) so if something external is deleting the containers, the playgrounds will know it.
Screenshots / video
podman-listen-events.mp4
Related issues
Fixes #110
Testing